-
Notifications
You must be signed in to change notification settings - Fork 751
feat(release): check for marketplace update #6426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Jan 24, 2025
justinmk3
reviewed
Jan 24, 2025
justinmk3
reviewed
Jan 24, 2025
justinmk3
reviewed
Jan 24, 2025
justinmk3
reviewed
Jan 24, 2025
justinmk3
reviewed
Jan 24, 2025
justinmk3
reviewed
Jan 24, 2025
justinmk3
approved these changes
Jan 27, 2025
tomcat323
added a commit
that referenced
this pull request
Feb 1, 2025
## Problem in #6426, a new release pipeline stage was added that checks the marketplace extension has been updated. This PR addes a stage check and only look for an existing version of the extension when in BETA. Output in beta: <img width="1074" alt="Screenshot 2025-01-30 at 12 45 07 PM" src="https://github.com/user-attachments/assets/ee0b8df7-cd89-4e44-a99b-9746134a8aa9" /> unblocks: https://pipelines.amazon.com/pipelines/AWSVSCodeInfrastructure --------- Co-authored-by: tomzu <[email protected]>
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Our release MCM currently has a step for each extension (Toolkit and Q) that requires the human operator to wait and check for the marketplace publish and then try to install from the marketplace. This uses human time and can easily be automated. ## Solution Added a final stage in release pipeline: https://code.amazon.com/reviews/CR-173945904/revisions/1#/commits that runs this YML build script that automatically installs and uninstalls the extension from marketplace on a two minute interval. When the version matches the new release version, the code-build succeeds: <img width="768" alt="Screenshot 2025-01-23 at 2 44 45 PM" src="https://github.com/user-attachments/assets/93f80a6d-573c-4524-995c-6491ecf1fb6f" /> When it doesn't, it keeps retrying until the timeout limit is reached (1 hour): <img width="694" alt="Screenshot 2025-01-23 at 4 52 07 PM" src="https://github.com/user-attachments/assets/c5433383-1194-4ec4-845a-4e63d8959cf7" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: tomzu <[email protected]>
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem in aws#6426, a new release pipeline stage was added that checks the marketplace extension has been updated. This PR addes a stage check and only look for an existing version of the extension when in BETA. Output in beta: <img width="1074" alt="Screenshot 2025-01-30 at 12 45 07 PM" src="https://github.com/user-attachments/assets/ee0b8df7-cd89-4e44-a99b-9746134a8aa9" /> unblocks: https://pipelines.amazon.com/pipelines/AWSVSCodeInfrastructure --------- Co-authored-by: tomzu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our release MCM currently has a step for each extension (Toolkit and Q) that requires the human operator to wait and check for the marketplace publish and then try to install from the marketplace. This uses human time and can easily be automated.
Solution
Added a final stage in release pipeline: https://code.amazon.com/reviews/CR-173945904/revisions/1#/commits
that runs this YML build script that automatically installs and uninstalls the extension from marketplace on a two minute interval.
When the version matches the new release version, the code-build succeeds:

When it doesn't, it keeps retrying until the timeout limit is reached (1 hour):

feature/xbranches will not be squash-merged at release time.